Bug 157879 – Silence warnings from svn propget when using newer versions of Subversion

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

Silence warnings from svn propget when using newer versions of Subversion

Created attachment 279340 [details]
Patch

[WebKit Commit Bot]

Attachment 279340 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Daniel Bates]

Comment on attachment 279340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279340&action=review

> Tools/ChangeLog:4
> +        Silence warnings from svn propget when using newer versions of Subversion.
> +

As mentioned by the style bot in comment #2, this ChangeLog is missing a bug URL. Please add the bug URL before landing.

> Tools/Scripts/prepare-ChangeLog:2000
> +            my $attrib = $attributeCache{$attr}{$subPath} || `$command 2> /dev/null`;

Please use File::Spec->devnull() instead of hardcoding /dev/null since this script should be platform agnostic.

> Tools/Scripts/svn-create-patch:175
> +    open PROPGET, "svn propget svn:mime-type $args '$escapedFile' 2> /dev/null |" or die;

Ditto.

[Alexey Proskuryakov]

What are these warnings, can they fixed for good?

(In reply to comment #4)
> What are these warnings, can they fixed for good?

svn propget warns if the property isn’t found:

$  svn propget myproperty .
svn: warning: W200017: Property 'myproperty' not found on ''
svn: E200000: A problem occurred; see other errors for details

I couldn’t find a way to fix it. One could avoid the warning by using svn proplist first to check for the property, but that seems unnecessarily more complex.

Committed <http://trac.webkit.org/r201242>.