Make LayoutUnit::operator bool() explicit.

[zalan]

This is in preparation to get LayoutUnit operator int() removed.

[zalan]

Created attachment 279314 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 279314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279314&action=review

> Source/WebCore/rendering/RenderView.cpp:280
> +    state.m_isPaginated = !!state.m_pageLogicalHeight;

I really think != 0 is better in these situations, and damn the style checker.

[zalan]

(In reply to comment #2)
> Comment on attachment 279314 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=279314&action=review
> 
> > Source/WebCore/rendering/RenderView.cpp:280
> > +    state.m_isPaginated = !!state.m_pageLogicalHeight;
> 
> I really think != 0 is better in these situations, and damn the style
> checker.

Agree! It might even be more correct to check if state.m_pageLogicalHeight > 0

[zalan]

Created attachment 279335 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 279335 [details]
Patch

Clearing flags on attachment: 279335

Committed r201124: <http://trac.webkit.org/changeset/201124>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.