RESOLVED FIXED157856
Remove LayoutUnit::operator unsigned(). 
https://bugs.webkit.org/show_bug.cgi?id=157856
Summary Remove LayoutUnit::operator unsigned().
alan
Reported 2016-05-18 12:27:47 PDT
Conversion from LayoutUnit to integral type is lossy. Don't do it implicitly.
Attachments
Patch (5.58 KB, patch)
2016-05-18 12:52 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (6.33 KB, patch)
2016-05-18 14:37 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2016-05-18 12:52:43 PDT
Created attachment 279275 [details] Patch
alan
Comment 2 2016-05-18 14:37:55 PDT
Created attachment 279284 [details] Patch
Simon Fraser (smfr)
Comment 3 2016-05-18 14:46:56 PDT
Comment on attachment 279284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=279284&action=review > Source/WebCore/page/EventHandler.cpp:1136 > + HitTestResult result(point, nonNegativePaddingHeight, nonNegativePaddingWidth, nonNegativePaddingHeight, nonNegativePaddingWidth); This should really take a BoxExtent<unsigned>, but that can be fixed later.
WebKit Commit Bot
Comment 4 2016-05-18 16:24:48 PDT
Comment on attachment 279284 [details] Patch Clearing flags on attachment: 279284 Committed r201114: <http://trac.webkit.org/changeset/201114>
WebKit Commit Bot
Comment 5 2016-05-18 16:24:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.