Bug 157856 - Remove LayoutUnit::operator unsigned().
Summary: Remove LayoutUnit::operator unsigned().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-18 12:27 PDT by zalan
Modified: 2016-05-18 16:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.58 KB, patch)
2016-05-18 12:52 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.33 KB, patch)
2016-05-18 14:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-05-18 12:27:47 PDT 
Conversion from LayoutUnit to integral type is lossy. Don't do it implicitly.
Comment 1 zalan 2016-05-18 12:52:43 PDT 
Created attachment 279275 [details]
Patch
Comment 2 zalan 2016-05-18 14:37:55 PDT 
Created attachment 279284 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-05-18 14:46:56 PDT 
Comment on attachment 279284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279284&action=review

> Source/WebCore/page/EventHandler.cpp:1136
> +    HitTestResult result(point, nonNegativePaddingHeight, nonNegativePaddingWidth, nonNegativePaddingHeight, nonNegativePaddingWidth);

This should really take a BoxExtent<unsigned>, but that can be fixed later.
Comment 4 WebKit Commit Bot 2016-05-18 16:24:48 PDT 
Comment on attachment 279284 [details]
Patch

Clearing flags on attachment: 279284

Committed r201114: <http://trac.webkit.org/changeset/201114>
Comment 5 WebKit Commit Bot 2016-05-18 16:24:52 PDT 
All reviewed patches have been landed.  Closing bug.