Bug 157850 - Web Inspector: race between frontend and backend both starting timeline recordings causes console assert
Summary: Web Inspector: race between frontend and backend both starting timeline recor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-18 11:18 PDT by BJ Burg
Modified: 2016-05-18 12:28 PDT (History)
8 users (show)

See Also:


Attachments
Proposed Fix (4.00 KB, patch)
2016-05-18 11:59 PDT, BJ Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-05-18 11:18:40 PDT
This is mostly harmless but now that I understand it, might as well fix it until we clean up TimelineManager.
Comment 1 Radar WebKit Bug Importer 2016-05-18 11:20:07 PDT
<rdar://problem/26349229>
Comment 2 BJ Burg 2016-05-18 11:59:31 PDT
Created attachment 279267 [details]
Proposed Fix

I tested auto-capturing on new navigations, which still works. I also tested that there is no longer an assert when Automation.inspectBrowsingContext starts profiling via InspectorFrontendAPI.togglePageProfiling.
Comment 3 Joseph Pecoraro 2016-05-18 12:04:53 PDT
Comment on attachment 279267 [details]
Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2016-05-18 12:28:16 PDT
Comment on attachment 279267 [details]
Proposed Fix

Clearing flags on attachment: 279267

Committed r201092: <http://trac.webkit.org/changeset/201092>
Comment 5 WebKit Commit Bot 2016-05-18 12:28:21 PDT
All reviewed patches have been landed.  Closing bug.