Bug 157846 - Web Inspector: InspectorFrontendAPI.setTimelineProfilingEnabled should not implicitly show Timelines tab
Summary: Web Inspector: InspectorFrontendAPI.setTimelineProfilingEnabled should not im...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
Keywords: InRadar
Depends on:
Reported: 2016-05-18 10:23 PDT by BJ Burg
Modified: 2016-05-18 14:49 PDT (History)
7 users (show)

See Also:

Proposed Fix (12.81 KB, patch)
2016-05-18 10:30 PDT, BJ Burg
timothy: review+
bburg: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-05-18 10:23:12 PDT
Let the WebKit client decide whether to show the timelines tab. If we are capturing a timeline recording in the background, then it shouldn't switch to Timelines.
Comment 1 Radar WebKit Bug Importer 2016-05-18 10:24:27 PDT
Comment 2 BJ Burg 2016-05-18 10:30:08 PDT
Created attachment 279261 [details]
Proposed Fix

I tested both the Start Timeline Recording menu item and implicitly starting a recording via Automation.inspectBrowsingContext. Both seemed to work fine with this change.
Comment 3 Matt Baker 2016-05-18 10:42:03 PDT
Comment on attachment 279261 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=279261&action=review

> Source/WebKit2/ChangeLog:8
> +        Add a seperate ShowTimelines message to WebInspector and WebInspectorUI. Have the

sp: separate
Comment 4 BJ Burg 2016-05-18 14:49:40 PDT
Committed r201101: <http://trac.webkit.org/changeset/201101>