Bug 157831 - Add a test for site-specific quirk in CSS parser
Summary: Add a test for site-specific quirk in CSS parser
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-18 00:14 PDT by Alex Christensen
Modified: 2016-05-25 04:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.93 KB, patch)
2016-05-18 00:15 PDT, Alex Christensen 		darin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-05-18 00:14:46 PDT 
Add a test for site-specific quirk in CSS parser
Comment 1 Alex Christensen 2016-05-18 00:15:16 PDT 
Created attachment 279224 [details]
Patch
Comment 2 Alexey Proskuryakov 2016-05-18 22:54:43 PDT 
Comment on attachment 279224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279224&action=review

> LayoutTests/ChangeLog:10
> +        * fast/css/site-specific-quirks-expected.html: Added.

Is the intention to use this for multiple quirks? Otherwise, the test should have a more descriptive name (wikimedia-content-specific-css-quirk?)

The bug should explain why we can't remove the quirk in foreseeable future (right now, it's not even related to the original bugs)

> LayoutTests/platform/mac-wk1/TestExpectations:217
>  js/dom/regress-157246.html
> +fast/css/site-specific-quirks.html

Could just as well use modern style with [ Skip ].

One way to avoid duplicating the expectations entry is to skip these tests in global TestExpectations, and enable them in LayoutTests/platform/wk2. Or an even better way - add LayoutTests/platform/wk1.
Comment 3 Darin Adler 2016-05-25 04:03:47 PDT 
Comment on attachment 279224 [details]
Patch

review- since we should address Alexey’s comments