Bug 157829 - Web Inspector: ugly gaps in Call Trees data grid when expanding more than one level
Summary: Web Inspector: ugly gaps in Call Trees data grid when expanding more than one...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P1 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-17 22:59 PDT by BJ Burg
Modified: 2016-05-18 15:15 PDT (History)
8 users (show)

See Also:


Attachments
[SCREENSHOT] gaps (90.97 KB, image/png)
2016-05-17 22:59 PDT, BJ Burg
no flags Details
WIP (1.21 KB, patch)
2016-05-18 12:58 PDT, Nikita Vasilyev
nvasilyev: review-
nvasilyev: commit-queue-
Details | Formatted Diff | Diff
Patch (2.30 KB, patch)
2016-05-18 14:17 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-05-17 22:59:57 PDT
Created attachment 279215 [details]
[SCREENSHOT] gaps

Yuk.
Comment 1 Radar WebKit Bug Importer 2016-05-17 23:00:52 PDT
<rdar://problem/26339922>
Comment 2 Timothy Hatcher 2016-05-18 07:32:34 PDT
This might have regressed in: http://trac.webkit.org/changeset/200918/trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css

Nikita, can you take a look?
Comment 3 Nikita Vasilyev 2016-05-18 08:02:25 PDT
Sure. I may have broken it.
Comment 4 Nikita Vasilyev 2016-05-18 12:58:51 PDT
Created attachment 279276 [details]
WIP

(In reply to comment #2)
> This might have regressed in:
> http://trac.webkit.org/changeset/200918/trunk/Source/WebInspectorUI/
> UserInterface/Views/DataGrid.css

It regressed there, indeed. The selector I wrote isn't specific enough.

This WIP fixes the issue, but it isn't a great solution.
I'm thinking of something better.
Comment 5 Nikita Vasilyev 2016-05-18 14:17:47 PDT
Created attachment 279282 [details]
Patch
Comment 6 WebKit Commit Bot 2016-05-18 15:15:23 PDT
Comment on attachment 279282 [details]
Patch

Clearing flags on attachment: 279282

Committed r201102: <http://trac.webkit.org/changeset/201102>
Comment 7 WebKit Commit Bot 2016-05-18 15:15:28 PDT
All reviewed patches have been landed.  Closing bug.