Bug 157826 – REGRESSION (r200534) Command-+ no longer zooms pages

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

REGRESSION (r200534) Command-+ no longer zooms pages

[Simon Fraser (smfr)]

Created attachment 279194 [details]
Patch

[Build Bot]

Comment on attachment 279194 [details]
Patch

Attachment 279194 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1339470

New failing tests:
fast/text-autosizing/ios/percent-adjust-percent-line-height.html
fast/text-autosizing/ios/line-height-text-autosizing.html
fast/text-autosizing/ios/percent-adjust-length-line-height.html
fast/text-autosizing/ios/percent-adjust-number-line-height.html

[Build Bot]

Created attachment 279199 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279194 [details]
Patch

Attachment 279194 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1339566

New failing tests:
fast/text/basic/013.html
fast/text/basic/006.html
storage/indexeddb/pending-activity-workers.html
fast/text/basic/008.html
fast/text/basic/009.html
fast/text/basic/generic-family-changes.html
fast/text/basic/012.html
fast/text/basic/004.html
fast/text-autosizing/ios/percent-adjust-length-line-height.html
fast/text/basic/002.html
fast/text/basic/001.html
fast/text/basic/generic-family-reset.html
fast/text-autosizing/ios/line-height-text-autosizing.html
fast/text/basic/003.html
fast/text/basic/011.html
fast/text-autosizing/ios/percent-adjust-percent-line-height.html
fast/text/basic/007.html
fast/text/basic/005.html
fast/text/basic/015.html
fast/text/basic/014.html
fast/text-autosizing/ios/percent-adjust-number-line-height.html

[Build Bot]

Created attachment 279200 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Simon Fraser (smfr)]

Created attachment 279201 [details]
Patch

[WebKit Commit Bot]

Attachment 279201 [details] did not pass style-queue:


ERROR: LayoutTests/platform/mac/TestExpectations:20:  Path does not exist.  [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:12:  Path does not exist.  [test/expectations] [5]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 279202 [details]
Patch

[Build Bot]

Comment on attachment 279202 [details]
Patch

Attachment 279202 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1339969

New failing tests:
http/tests/performance/performance-resource-timing-cached-entries.html

[Build Bot]

Created attachment 279207 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Build Bot]

Comment on attachment 279202 [details]
Patch

Attachment 279202 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1339925

New failing tests:
fast/text/basic/013.html
fast/text/basic/008.html
fast/text/basic/009.html
fast/text/basic/011.html
fast/text/basic/012.html
fast/text/basic/004.html
fast/text/basic/generic-family-changes.html
fast/text/basic/002.html
fast/text/basic/001.html
fast/text/basic/generic-family-reset.html
fast/text/basic/003.html
fast/text/basic/006.html
fast/text/basic/007.html
fast/text/basic/005.html
fast/text/basic/015.html
fast/text/basic/014.html

[Build Bot]

Created attachment 279208 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Simon Fraser (smfr)]

I don't understand the fast/text/basic/ failures, and can't reproduce them locally.

[Simon Fraser (smfr)]

The problem here is in DumpRenderTree we have:

#if ENABLE(IOS_TEXT_AUTOSIZING)
    [preferences _setTextAutosizingEnabled:NO];
#endif

yet ENABLE_IOS_TEXT_AUTOSIZING is not defined because the xcconfig files for DRT and WTR don't have all the feature defines stuff in them.

[Simon Fraser (smfr)]

Filed bug 157828.

[Simon Fraser (smfr)]

Created attachment 279214 [details]
Patch

[Build Bot]

Comment on attachment 279214 [details]
Patch

Attachment 279214 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1340943

New failing tests:
fast/text/firstline/003.html

[Build Bot]

Created attachment 279219 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Simon Fraser (smfr)]

setPageZoomFactor is carrying over from a test (or its expected) in WK1 because [webView resetPageZoom:nil]; isn't enough to reset internals.setPageZoomFactor.

[Simon Fraser (smfr)]

Created attachment 279263 [details]
Patch

[Simon Fraser (smfr)]

https://trac.webkit.org/r201090

[Ryan Haddad]

This change may have caused perf test failures:
<https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Perf%29/builds/2033>

[Simon Fraser (smfr)]

I removed that errant WTFLogAlways in http://trac.webkit.org/changeset/201103

[Darin Adler]

Comment on attachment 279263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279263&action=review

> Tools/ChangeLog:10
> +        * DumpRenderTree/mac/DumpRenderTree.mm:
> +        (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828).

You say that these were doing nothing, but actually they were #if'ing out the code! So now the code is compiled, unconditionally. I suppose that’s a good thing. Main problem I would expect is that they would fail to compile if we turned off those features?