Bug 157820 - Disable default user gesture requirement for audio playback on Mac
Summary: Disable default user gesture requirement for audio playback on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-17 16:35 PDT by Jer Noble
Modified: 2016-05-18 15:51 PDT (History)
0 users

See Also:

Attachments
Patch (3.63 KB, patch)
2016-05-17 16:39 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (3.70 KB, patch)
2016-05-18 08:24 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-05-17 16:35:22 PDT 
Disable user gesture requirement for audio playback on Mac
Comment 1 Jer Noble 2016-05-17 16:39:14 PDT 
Created attachment 279183 [details]
Patch
Comment 2 Jon Lee 2016-05-17 19:42:36 PDT 
Comment on attachment 279183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279183&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:143
>          _mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeAll;

These two lines are mixed up, aren't they? And/or a separate assignment to WKAudiovisualMediaTypeNone?
Comment 3 Jer Noble 2016-05-18 08:24:42 PDT 
Created attachment 279252 [details]
Patch
Comment 4 Jer Noble 2016-05-18 15:51:11 PDT 
Comment on attachment 279252 [details]
Patch

Clearing flags on attachment: 279252

Committed r201110: <http://trac.webkit.org/changeset/201110>
Comment 5 Jer Noble 2016-05-18 15:51:15 PDT 
All reviewed patches have been landed.  Closing bug.