Bug 157813 – Web Inspector: NavigationSidebarPanel should coordinate item selection between its tree outlines

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

* SUMMARY
NavigationSidebarPanel should coordinate item selection between its tree outlines. Debugger sidebar panel deselect tree elements as needed to prevent two selections in the sidebar, but this should be done by the base class.

* NOTE
DebuggerSidebarPanel._treeSelectionDidChange shadows the event listener in NavigationSidebarPanel, which means NavigationSidebarPanel._selectedContentTreeOutline will be in a base state. I'll address the issue as part of this change.

[Radar WebKit Bug Importer]

<rdar://problem/26331779>

[Radar WebKit Bug Importer]

<rdar://problem/26331796>

[Matt Baker]

Created attachment 279184 [details]
[Patch] Proposed Fix

[Timothy Hatcher]

Comment on attachment 279184 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=279184&action=review

> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:653
> +        if (treeElement) {

Return early instead?

> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:664
> +        this._selectedContentTreeOutline = selectedTreeOutline;

Not used?

[Matt Baker]

Comment on attachment 279184 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=279184&action=review

>> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:664
>> +        this._selectedContentTreeOutline = selectedTreeOutline;
> 
> Not used?

Used in NavigationSidebarPanel.show.

[Matt Baker]

Created attachment 279193 [details]
[Patch] Proposed Fix

[Matt Baker]

Created attachment 279198 [details]
[Patch] For Landing

[WebKit Commit Bot]

Comment on attachment 279198 [details]
[Patch] For Landing

Clearing flags on attachment: 279198

Committed r201068: <http://trac.webkit.org/changeset/201068>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.