Bug 157807 – Add test262 test files/yaml.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Keith Miller]

...

[Keith Miller]

Created attachment 279157 [details]
Patch

[Keith Miller]

I'm just going to land this. This patch adds a bunch of files that won't be run yet anyway.

[Csaba Osztrogonác]

Please don't land it now, we could and should make 
the test262.yaml file less verbose and redundant.

For example, harness/assert.js and harness.sta js are included
by all "runTest262" test. I prefer adding these common harness
files to includeFiles in runTest262 function instead.

Additionally we could remove the ugly relative paths to 
harness files, all of them are in the same harness directory.

[Csaba Osztrogonác]

typo: donePrintHandle.js -> doneprintHandle.js in the generated yaml file

It would be great to mention which revision of test262 is checked in.
At least in the bug report and commit log, but it would be better
to have a revision.txt file or something similar.

[Alex Christensen]

Should this still be r?

[Csaba Osztrogonác]

landed in https://trac.webkit.org/changeset/203270

(In reply to comment #4)
> It would be great to mention which revision of test262 is checked in.
> At least in the bug report and commit log, but it would be better
> to have a revision.txt file or something similar.

I can't find the revision of test262 in that commit log. :(
Please add a revision file, or mention it in the commit log
which updates something in the test262 directory.

[Csaba Osztrogonác]

(In reply to comment #6)
> landed in https://trac.webkit.org/changeset/203270
> 
> (In reply to comment #4)
> > It would be great to mention which revision of test262 is checked in.
> > At least in the bug report and commit log, but it would be better
> > to have a revision.txt file or something similar.
> 
> I can't find the revision of test262 in that commit log. :(
> Please add a revision file, or mention it in the commit log
> which updates something in the test262 directory.

Ping?

[Keith Miller]

(In reply to comment #7)
> (In reply to comment #6)
> > landed in https://trac.webkit.org/changeset/203270
> > 
> > (In reply to comment #4)
> > > It would be great to mention which revision of test262 is checked in.
> > > At least in the bug report and commit log, but it would be better
> > > to have a revision.txt file or something similar.
> > 
> > I can't find the revision of test262 in that commit log. :(
> > Please add a revision file, or mention it in the commit log
> > which updates something in the test262 directory.
> 
> Ping?

Good idea. I opened a bugzilla: https://bugs.webkit.org/show_bug.cgi?id=159937

[Yusuke Suzuki]

*** Bug 144241 has been marked as a duplicate of this bug. ***