Bug 157803 – webkitEnterFullscreen() does not require a user gesture when RequireUserGestureForAudioRateChange is set.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

webkitEnterFullscreen() does not require a user gesture when RequireUserGestureForAudioRateChange is set.

[Jer Noble]

Created attachment 279139 [details]
Patch

[Build Bot]

Comment on attachment 279139 [details]
Patch

Attachment 279139 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1337532

New failing tests:
media/media-fullscreen-inline.html
media/video-autoplay-allowed-but-fullscreen-required.html

[Build Bot]

Created attachment 279141 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279139 [details]
Patch

Attachment 279139 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1337615

New failing tests:
media/media-fullscreen-inline.html
media/video-autoplay-allowed-but-fullscreen-required.html

[Build Bot]

Created attachment 279143 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 279139 [details]
Patch

Attachment 279139 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1337620

New failing tests:
media/media-fullscreen-inline.html
media/video-autoplay-allowed-but-fullscreen-required.html

[Build Bot]

Created attachment 279145 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Jer Noble]

Created attachment 279159 [details]
Patch

[Eric Carlson]

Comment on attachment 279159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279159&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:472
> +        // Relax RequireUserGestureForFullscreen when videoPlaybackRequiresUserGesture and audioPlaybackRequiresUserGesture is not set:

Nit: ':' -> '.'

[Build Bot]

Comment on attachment 279159 [details]
Patch

Attachment 279159 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1338056

New failing tests:
http/tests/performance/performance-resource-timing-cached-entries.html

[Build Bot]

Created attachment 279163 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Jer Noble]

Committed r201109: <http://trac.webkit.org/changeset/201109>