Bug 157802 - Web Inspector: inspector tests should redirect and log console.trace() calls in test output
Summary: Web Inspector: inspector tests should redirect and log console.trace() calls ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-17 11:04 PDT by BJ Burg
Modified: 2016-05-17 15:03 PDT (History)
8 users (show)

See Also:


Attachments
Proposed Fix (4.30 KB, patch)
2016-05-17 12:52 PDT, BJ Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-05-17 11:04:10 PDT
Not sure how to implement
Comment 1 Radar WebKit Bug Importer 2016-05-17 11:06:54 PDT
<rdar://problem/26325671>
Comment 2 BJ Burg 2016-05-17 11:41:20 PDT
Output from current patch:

-- Running test case: ShortTaskCompletesWithoutYielding
LOG: Hit
TRACE: 
#0: _didFinish (TestCombined.js:3619:22)
#1: _processPendingItems (TestCombined.js:3607:24)
#2: start (TestCombined.js:3571:34)
#3: (anonymous) (unknown)
#4: initializePromise [native code]
#5: Promise [native code]
#6: (anonymous) (TestCombined.js:1214:35)
#7: promiseReactionJob [native code]

Looks pretty good to me!
Comment 3 BJ Burg 2016-05-17 12:52:40 PDT
Created attachment 279151 [details]
Proposed Fix
Comment 4 Joseph Pecoraro 2016-05-17 14:59:40 PDT
Comment on attachment 279151 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=279151&action=review

> Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js:144
> +                    throw new Exception();

This seems rather ambiguous. "new Exception" alone is a runtime exception because there is no such thing as "Exception", which makes the `throw` unnecessary.

I tend to write something obvious that causes an exception, like: "({}).x.x" or "this.property.does.not.exist"
Comment 5 WebKit Commit Bot 2016-05-17 15:03:50 PDT
Comment on attachment 279151 [details]
Proposed Fix

Clearing flags on attachment: 279151

Committed r201048: <http://trac.webkit.org/changeset/201048>
Comment 6 WebKit Commit Bot 2016-05-17 15:03:55 PDT
All reviewed patches have been landed.  Closing bug.