Bug 157802 – Web Inspector: inspector tests should redirect and log console.trace() calls in test output

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Not sure how to implement

[Radar WebKit Bug Importer]

<rdar://problem/26325671>

[Blaze Burg]

Output from current patch:

-- Running test case: ShortTaskCompletesWithoutYielding
LOG: Hit
TRACE: 
#0: _didFinish (TestCombined.js:3619:22)
#1: _processPendingItems (TestCombined.js:3607:24)
#2: start (TestCombined.js:3571:34)
#3: (anonymous) (unknown)
#4: initializePromise [native code]
#5: Promise [native code]
#6: (anonymous) (TestCombined.js:1214:35)
#7: promiseReactionJob [native code]

Looks pretty good to me!

[Blaze Burg]

Created attachment 279151 [details]
Proposed Fix

[Joseph Pecoraro]

Comment on attachment 279151 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=279151&action=review

> Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js:144
> +                    throw new Exception();

This seems rather ambiguous. "new Exception" alone is a runtime exception because there is no such thing as "Exception", which makes the `throw` unnecessary.

I tend to write something obvious that causes an exception, like: "({}).x.x" or "this.property.does.not.exist"

[WebKit Commit Bot]

Comment on attachment 279151 [details]
Proposed Fix

Clearing flags on attachment: 279151

Committed r201048: <http://trac.webkit.org/changeset/201048>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.