It would be good to sync the DOM exceptions with https://heycam.github.io/webidl/#idl-DOMException-error-names? This could be used to almost always reject promises using reject(ExceptionCode) in most cases.
Created attachment 279121 [details] Patch
Attachment 279121 [details] did not pass style-queue: ERROR: Source/WebCore/dom/ExceptionCode.h:68: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:69: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:70: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:71: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:72: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:73: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:74: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:75: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:76: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:77: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 10 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
> ERROR: Source/WebCore/dom/ExceptionCode.h:68: enum members should use > InterCaps with an initial capital letter or initial 'k' for C-style enums. > [readability/enum_casing] [4] I was not sure of the style for new errors. I guess camel-based naming would be preferable for new errors.
Created attachment 279123 [details] Fixing mac build
Attachment 279123 [details] did not pass style-queue: ERROR: Source/WebCore/dom/ExceptionCode.h:68: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:69: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:70: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:71: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:72: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:73: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:74: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:75: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:76: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:77: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 10 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 279123 [details] Fixing mac build Attachment 279123 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1336903 New failing tests: fast/dynamic/015.html fast/inspector-support/uncaught-dom1-exception.html svg/dom/SVGTransformList.html fast/dom/HTMLSelectElement/select-selectedIndex.html inspector/debugger/setPauseOnExceptions-none.html fast/inspector-support/uncaught-dom8-exception.html fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html fast/inspector-support/uncaught-dom3-exception.html crypto/crypto-random-values-types.html fast/dom/Geolocation/argument-types.html fast/dom/insertAdjacentHTML-DocumentFragment-crash.html inspector/debugger/setPauseOnExceptions-uncaught.html fast/regions/selection/crash-deselect.html inspector/debugger/regress-133182.html inspector/debugger/setPauseOnExceptions-all.html js/dom/reflect-set-onto-dom.html fast/dom/Geolocation/not-enough-arguments.html
Created attachment 279125 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 279123 [details] Fixing mac build Attachment 279123 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1336933 New failing tests: fast/dynamic/015.html fast/inspector-support/uncaught-dom1-exception.html svg/dom/SVGTransformList.html fast/dom/HTMLSelectElement/select-selectedIndex.html inspector/debugger/setPauseOnExceptions-none.html fast/inspector-support/uncaught-dom8-exception.html fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html fast/inspector-support/uncaught-dom3-exception.html crypto/crypto-random-values-types.html fast/dom/Geolocation/argument-types.html fast/dom/insertAdjacentHTML-DocumentFragment-crash.html inspector/debugger/setPauseOnExceptions-uncaught.html fast/regions/selection/crash-deselect.html inspector/debugger/regress-133182.html inspector/debugger/setPauseOnExceptions-all.html js/dom/reflect-set-onto-dom.html fast/dom/Geolocation/not-enough-arguments.html
Created attachment 279127 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 279123 [details] Fixing mac build Attachment 279123 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1336934 New failing tests: fast/dynamic/015.html fast/inspector-support/uncaught-dom1-exception.html editing/selection/caret-ltr-2-left.html svg/dom/SVGTransformList.html fast/dom/insertAdjacentHTML-DocumentFragment-crash.html editing/selection/caret-rtl.html fast/inspector-support/uncaught-dom8-exception.html fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html fast/inspector-support/uncaught-dom3-exception.html crypto/crypto-random-values-types.html editing/selection/caret-ltr.html editing/selection/caret-ltr-2.html fast/dom/Geolocation/argument-types.html js/dom/reflect-set-onto-dom.html editing/selection/caret-ltr-right.html fast/regions/selection/crash-deselect.html editing/selection/caret-rtl-2.html editing/selection/caret-rtl-2-left.html fast/dom/HTMLSelectElement/select-selectedIndex.html editing/selection/caret-rtl-right.html fast/dom/Geolocation/not-enough-arguments.html
Created attachment 279129 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Comment on attachment 279123 [details] Fixing mac build Attachment 279123 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1336962 New failing tests: fast/dynamic/015.html fast/inspector-support/uncaught-dom1-exception.html svg/dom/SVGTransformList.html fast/dom/HTMLSelectElement/select-selectedIndex.html inspector/debugger/setPauseOnExceptions-none.html fast/inspector-support/uncaught-dom8-exception.html fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html fast/inspector-support/uncaught-dom3-exception.html crypto/crypto-random-values-types.html fast/dom/Geolocation/argument-types.html fast/dom/insertAdjacentHTML-DocumentFragment-crash.html inspector/debugger/setPauseOnExceptions-uncaught.html fast/regions/selection/crash-deselect.html inspector/debugger/regress-133182.html inspector/debugger/setPauseOnExceptions-all.html js/dom/reflect-set-onto-dom.html fast/dom/Geolocation/not-enough-arguments.html
Created attachment 279131 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 279153 [details] Rebasing tests
Attachment 279153 [details] did not pass style-queue: ERROR: Source/WebCore/dom/ExceptionCode.h:68: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:69: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:70: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:71: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:72: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:73: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:74: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:75: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:76: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/ExceptionCode.h:77: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 10 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 279153 [details] Rebasing tests Attachment 279153 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1337988 New failing tests: editing/selection/caret-ltr-2-left.html editing/selection/caret-rtl.html editing/selection/caret-ltr.html editing/selection/caret-ltr-2.html editing/selection/caret-ltr-right.html editing/selection/caret-rtl-2.html editing/selection/caret-rtl-2-left.html editing/selection/caret-rtl-right.html
Created attachment 279161 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Comment on attachment 279153 [details] Rebasing tests Attachment 279153 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1338432 Number of test failures exceeded the failure limit.
Created attachment 279173 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 279222 [details] Rebasing ios-sim tests
Patch is changing some error types for getUserMedia, WebRTC and HTML media element. I tried to follow the latest spec. I don't think that this would cause compatibility issues, except maybe for getUserMedia.
Comment on attachment 279222 [details] Rebasing ios-sim tests View in context: https://bugs.webkit.org/attachment.cgi?id=279222&action=review > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:198 > + // FIXME: The promise should be rejected with an OverconstrainedError. Please file a bug and include the number here. > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:-207 > - // FIXME: Replace NavigatorUserMediaError with MediaStreamError (see bug 143335) > - m_promise.reject(NavigatorUserMediaError::create(NavigatorUserMediaError::permissionDeniedErrorName(), emptyString())); Please close bug 143335 when this lands.
Created attachment 279249 [details] Patch for landing
Thanks for the review. > > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:198 > > + // FIXME: The promise should be rejected with an OverconstrainedError. > > Please file a bug and include the number here. I filed bug 157839. > > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:-207 > > - // FIXME: Replace NavigatorUserMediaError with MediaStreamError (see bug 143335) > > - m_promise.reject(NavigatorUserMediaError::create(NavigatorUserMediaError::permissionDeniedErrorName(), emptyString())); > > Please close bug 143335 when this lands. OK.
Comment on attachment 279249 [details] Patch for landing Clearing flags on attachment: 279249 Committed r201080: <http://trac.webkit.org/changeset/201080>
All reviewed patches have been landed. Closing bug.