Bug 157788 - <form> in quirks mode should have margin-block-end: 1em
Summary: <form> in quirks mode should have margin-block-end: 1em
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: FromImplementor, InRadar
Depends on:
Blocks:
 
Reported: 2016-05-17 02:38 PDT by Simon Pieters (:zcorpan)
Modified: 2018-10-01 11:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.27 KB, patch)
2018-10-01 09:52 PDT, Simon Pieters (:zcorpan) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pieters (:zcorpan) 2016-05-17 02:38:59 PDT 
See https://github.com/whatwg/html/pull/1252


A form in quirks mode has a block-end margin in Gecko/Edge; bottom margin in WebKit/Chromium.

<style>html { writing-mode: vertical-lr } </style>
x<form id=form></form>y
<script>
w('marginRight ' + getComputedStyle(form).marginRight);
w('marginBottom ' + getComputedStyle(form).marginBottom);
</script>

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4197

https://github.com/WebKit/webkit/blob/master/Source/WebCore/css/quirks.css#L53
Comment 1 Simon Pieters (:zcorpan) 2018-10-01 09:52:33 PDT 
Created attachment 351255 [details]
Patch
Comment 2 Simon Pieters (:zcorpan) 2018-10-01 10:09:15 PDT 
wpt PR https://github.com/web-platform-tests/wpt/pull/13292
Comment 3 Simon Pieters (:zcorpan) 2018-10-01 10:28:32 PDT 
I got the export script working now: https://github.com/web-platform-tests/wpt/pull/13293
Comment 4 WebKit Commit Bot 2018-10-01 11:08:44 PDT 
Comment on attachment 351255 [details]
Patch

Clearing flags on attachment: 351255

Committed r236673: <https://trac.webkit.org/changeset/236673>
Comment 5 WebKit Commit Bot 2018-10-01 11:08:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-01 11:10:18 PDT 
<rdar://problem/44914383>