Bug 157783 – REGRESSION(r54729): Line breaking in complex mixed-direction text is inconsistent across page refreshes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

REGRESSION(r54729): Line breaking in complex mixed-direction text is inconsistent across page refreshes

[Myles C. Maxfield]

Created attachment 279090 [details]
WIP

[Myles C. Maxfield]

Created attachment 279095 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/22908924>

[Said Abou-Hallawa]

Comment on attachment 279095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279095&action=review

Unofficial r=me.

> Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:461
> +        b = false;

Can't we just initialize mappedIndices like this:

Vector<bool, 64> mappedIndices(m_stringLength, false);

[alan]

Comment on attachment 279095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279095&action=review

> Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:461
> +    for (auto& b : mappedIndices)
> +        b = false;

Don't we have fill c'tor? like std::vector<bool> mappedIndices(64, false);

[Build Bot]

Comment on attachment 279095 [details]
Patch

Attachment 279095 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1334444

New failing tests:
http/tests/performance/performance-resource-timing-cached-entries.html

[Build Bot]

Created attachment 279101 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Myles C. Maxfield]

Created attachment 279106 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 279106 [details]
Patch

Clearing flags on attachment: 279106

Committed r201015: <http://trac.webkit.org/changeset/201015>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.