Bug 157780 - Tidy unused parameters with build flags in isValidKeywordPropertyAndValue
Summary: Tidy unused parameters with build flags in isValidKeywordPropertyAndValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-16 19:40 PDT by Dean Jackson
Modified: 2016-05-17 12:04 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2016-05-16 19:44 PDT, Dean Jackson
achristensen: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-05-16 19:40:04 PDT
Tidy unused parameters with build flags in isValidKeywordPropertyAndValue
Comment 1 Dean Jackson 2016-05-16 19:44:33 PDT
Created attachment 279083 [details]
Patch
Comment 2 WebKit Commit Bot 2016-05-16 23:34:12 PDT
Comment on attachment 279083 [details]
Patch

Rejecting attachment 279083 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 279083, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/1334951
Comment 3 Radar WebKit Bug Importer 2016-05-17 12:00:46 PDT
<rdar://problem/26327312>
Comment 4 Dean Jackson 2016-05-17 12:04:09 PDT
Committed r201036: <http://trac.webkit.org/changeset/201036>