WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
157753
Consider renaming activeDOMObjectsAreSuspended() to areActiveDOMObjectsSuspendingOrSuspended() for clarity
https://bugs.webkit.org/show_bug.cgi?id=157753
Summary
Consider renaming activeDOMObjectsAreSuspended() to areActiveDOMObjectsSuspen...
Ada Chan
Reported
2016-05-16 13:49:26 PDT
ScriptExecutionContext::stopActiveDOMObjects() has always set m_activeDOMObjectsAreStopped to true before stopping the objects. For ScriptExecutionContext::suspendActiveDOMObjects(), we've recently changed it to set m_activeDOMObjectsAreSuspended to true earlier to be consistent with the stop case in
http://trac.webkit.org/changeset/200965
. Since the underlying booleans are updated right before we actually suspend/stop the objects, we should rename them to m_activeDOMObjectsAreSuspendingOrSuspended m_activeDOMObjectsAreStoppingOrStopped for clarity.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug