Bug 157753 - Consider renaming activeDOMObjectsAreSuspended() to areActiveDOMObjectsSuspendingOrSuspended() for clarity
Summary: Consider renaming activeDOMObjectsAreSuspended() to areActiveDOMObjectsSuspen...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-16 13:49 PDT by Ada Chan
Modified: 2016-05-16 22:33 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2016-05-16 13:49:26 PDT 
ScriptExecutionContext::stopActiveDOMObjects() has always set m_activeDOMObjectsAreStopped to true before stopping the objects.  For ScriptExecutionContext::suspendActiveDOMObjects(), we've recently changed it to set m_activeDOMObjectsAreSuspended to true earlier to be consistent with the stop case in http://trac.webkit.org/changeset/200965.

Since the underlying booleans are updated right before we actually suspend/stop the objects, we should rename them to

m_activeDOMObjectsAreSuspendingOrSuspended
m_activeDOMObjectsAreStoppingOrStopped

for clarity.