Modernize Track classes' code a bit.
Created attachment 278995 [details] Patch
Created attachment 278996 [details] Patch
Comment on attachment 278996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278996&action=review > Source/WebCore/html/HTMLMediaElement.cpp:4015 > + TextTrack* track = trackList.item(i); Why not use auto& here? > Source/WebCore/html/track/VideoTrackList.cpp:90 > + auto& track = downcast<VideoTrack>(*m_inbandTracks[i]); > + if (track.selected()) Nit: is the local necessary?
Comment on attachment 278996 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278996&action=review >> Source/WebCore/html/HTMLMediaElement.cpp:4015 >> + TextTrack* track = trackList.item(i); > > Why not use auto& here? Will do. >> Source/WebCore/html/track/VideoTrackList.cpp:90 >> + if (track.selected()) > > Nit: is the local necessary? I guess not :) Will update.
Created attachment 279020 [details] Patch
Comment on attachment 279020 [details] Patch Clearing flags on attachment: 279020 Committed r200943: <http://trac.webkit.org/changeset/200943>
All reviewed patches have been landed. Closing bug.