Bug 157733 - [GTK][CMake] DerivedSources should be compiled with -Wno-unused-parameter
Summary: [GTK][CMake] DerivedSources should be compiled with -Wno-unused-parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 155047
  Show dependency tree / graph
 
Reported: 2016-05-15 17:51 PDT by Michael Catanzaro
Modified: 2017-07-13 11:42 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2016-05-15 18:39 PDT, Michael Catanzaro 		ossy: review-
ossy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-05-15 17:51:07 PDT 
DerivedSources should be compiled with -Wno-unused-parameter, to avoid useless warnings in Geoclue2Interface.c.
Comment 1 Michael Catanzaro 2016-05-15 18:39:09 PDT 
Created attachment 278989 [details]
Patch
Comment 2 Darin Adler 2016-05-23 20:54:34 PDT 
(In reply to comment #0)
> DerivedSources should be compiled with -Wno-unused-parameter, to avoid
> useless warnings in Geoclue2Interface.c.

We really want to compile all derived sources this way, just because of that one file?
Comment 3 Csaba Osztrogonác 2016-05-24 00:53:30 PDT 
Comment on attachment 278989 [details]
Patch

I haven't seen this warning, maybe geoclue is disabled in my build.

But I agree with Darin, we shouldn't disable unused parameter warnings because of 
one file. I prefer set_source_file_properties() for this problematic generated source.
Comment 4 Michael Catanzaro 2017-07-13 11:42:44 PDT 
(In reply to Csaba Osztrogonác from comment #3)
> Comment on attachment 278989 [details]
> Patch
> 
> I haven't seen this warning, maybe geoclue is disabled in my build.
> 
> But I agree with Darin, we shouldn't disable unused parameter warnings
> because of 
> one file. I prefer set_source_file_properties() for this problematic
> generated source.

I guess I must have done this at some point in a different bug, because I think I remember fixing it, and it definitely does not occur anymore.