Bug 157732 - woff2_dec.cc triggers -Wsign-compare, -Wunused-but-set-variable
Summary: woff2_dec.cc triggers -Wsign-compare, -Wunused-but-set-variable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 155047
  Show dependency tree / graph
 
Reported: 2016-05-15 17:50 PDT by Michael Catanzaro
Modified: 2016-05-23 18:53 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.17 KB, patch)
2016-05-15 18:07 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-05-15 17:50:02 PDT 
woff2_dec.cc triggers -Wsign-compare
Comment 1 Michael Catanzaro 2016-05-15 18:06:16 PDT 
It's also triggering -Wunused-but-set-variable

Instead of fixing these, let's suppress them, since it's third-party code. We could use a heavy hammer and use -w to suppress all warnings from third-party code, but let's start with suppressing just the problematic ones so we can see if new warnings get introduced in the future.
Comment 2 Michael Catanzaro 2016-05-15 18:07:54 PDT 
Created attachment 278987 [details]
Patch
Comment 3 WebKit Commit Bot 2016-05-23 18:53:44 PDT 
Comment on attachment 278987 [details]
Patch

Clearing flags on attachment: 278987

Committed r201313: <http://trac.webkit.org/changeset/201313>
Comment 4 WebKit Commit Bot 2016-05-23 18:53:49 PDT 
All reviewed patches have been landed.  Closing bug.