Bug 157714 – Web Inspector: breakpoints in sourceURL named scripts are not persisted

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

This makes it very difficult to debug our injected scripts using breakpoints. I don't think this is a regression.

STEPS TO REPRODUCE:

Using an engineering build, open the debugger tab.
Select the __WebInspectorInjectedScript__ resource.
Set a breakpoint anywhere.
Reload.

EXPECTED:

The breakpoint should be restored on reload

ACTUAL:

The breakpoint is not restored

[Radar WebKit Bug Importer]

<rdar://problem/26287099>

[Blaze Burg]

Created attachment 278960 [details]
Proposed Fix

Still need to run tests and such, but it works for injected and normal scripts in my basic testing.

[Blaze Burg]

Comment on attachment 278960 [details]
Proposed Fix

I did not detect any test regressions caused by this patch, and it seems to work fine locally. Removing 'WIP' from patch, review away!

[Joseph Pecoraro]

Comment on attachment 278960 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278960&action=review

r=me

I don't particularly like the name contentIdentifier, but I don't have a better suggestion.

> Source/WebInspectorUI/UserInterface/Models/Breakpoint.js:38
> +            var contentIdentifier = sourceCodeLocationOrInfo.contentIdentifier || sourceCodeLocationOrInfo.url;

We should throw a comment in here about sourceCodeLocationOrInfo that the info portion is legacy and can eventually be removed.

[Blaze Burg]

(In reply to comment #4)
> Comment on attachment 278960 [details]
> Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278960&action=review
> 
> r=me
> 
> I don't particularly like the name contentIdentifier, but I don't have a
> better suggestion.

I hear ya. The other straightforward suggestion is contentURL.

> 
> > Source/WebInspectorUI/UserInterface/Models/Breakpoint.js:38
> > +            var contentIdentifier = sourceCodeLocationOrInfo.contentIdentifier || sourceCodeLocationOrInfo.url;
> 
> We should throw a comment in here about sourceCodeLocationOrInfo that the
> info portion is legacy and can eventually be removed.

[Blaze Burg]

Committed r201019: <http://trac.webkit.org/changeset/201019>