Bug 157711 – Use new Web IDL dictionary support for MediaSession.setMetadata()

• Status: REOPENED
• Component: Bindings

[Chris Dumez]

Use new Web IDL dictionary support for MediaSession.setMetadata()

[Chris Dumez]

Created attachment 278944 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 278944 [details]
Patch

Clearing flags on attachment: 278944

Committed r200925: <http://trac.webkit.org/changeset/200925>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 278944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278944&action=review

> Source/WebCore/Modules/mediasession/MediaSession.h:56
> +    struct MediaMetadataInit {

I am surprised this works. Maybe the bindings are inside an #if and not compiling. The name for the struct is supposed to be MediaSession::MetadataInit, not MediaSession::MediaMetadataInit. Maybe there is a bug in the GetNestedClassName function in CodeGeneratorJS.pm?

[Darin Adler]

Yes, looks like this will fail to compile if ENABLE(MEDIA_SESSION) is true.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 157725

[Chris Dumez]

(In reply to comment #5)
> Yes, looks like this will fail to compile if ENABLE(MEDIA_SESSION) is true.

Ok, I will roll out :( I was convinced this was enabled on Mac for some reason.

[Darin Adler]

We can definitely redo it; we just need to turn on compiling on some platform. I find it really hard to maintain code that is not compiled!

[Ahmad Saleem]

This was rolled out and I noticed that there are difference in Webkit MediaSession.IDL with Chrome / Blink:

Webkit Link - https://github.com/WebKit/WebKit/blob/main/Source/WebCore/Modules/mediasession/MediaSession.idl

Chromium / Blink - https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/mediasession/media_session.idl?q=media_Session.idl

Chris - is this needed? Thanks!