RESOLVED FIXED 157709
Web Inspector: Many DataGrid instances do not save/restore their scroll position 
https://bugs.webkit.org/show_bug.cgi?id=157709
Summary Web Inspector: Many DataGrid instances do not save/restore their scroll position
Timothy Hatcher
Reported 2016-05-14 09:23:39 PDT
There are two bugs here. ContentView's are never restoring their scroll positions from BackFrowardEntry as expected because a new BackFrowardEntry is created each time. Second, many ContentViews don't implement scrollableElements.
Attachments
Patch (12.83 KB, patch)
2016-05-14 12:10 PDT, Timothy Hatcher 		bburg: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-05-14 09:23:57 PDT
<rdar://problem/26286090>
Timothy Hatcher
Comment 2 2016-05-14 12:10:30 PDT
Created attachment 278941 [details] Patch
Blaze Burg
Comment 3 2016-05-16 08:43:19 PDT
Comment on attachment 278941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278941&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js:96 > + // is undefined, so we want to show with a state last used. Initially I was worried this could reuse scroll positions where it's not appropriate. For example, two timeline recordings are made, and switching between recordings would reuse the last scroll positions. I'm not sure this will be a problem though, since we create new ContentViews for each representedObject instance. Or, at least, that's what we should be doing. There may be some places that still use singletons (i.e., storage views) where this may have undesirable behavior.
Timothy Hatcher
Comment 4 2016-05-16 08:46:17 PDT
Comment on attachment 278941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=278941&action=review >> Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js:96 >> + // is undefined, so we want to show with a state last used. > > Initially I was worried this could reuse scroll positions where it's not appropriate. For example, two timeline recordings are made, and switching between recordings would reuse the last scroll positions. > > I'm not sure this will be a problem though, since we create new ContentViews for each representedObject instance. Or, at least, that's what we should be doing. There may be some places that still use singletons (i.e., storage views) where this may have undesirable behavior. Yes, we have different views in that case.
Timothy Hatcher
Comment 5 2016-05-16 10:41:34 PDT
https://trac.webkit.org/r200947
Note You need to log in before you can comment on or make changes to this bug.