Bug 157708 - Extend protector naming code style guideline to cover RetainPtr with CF/ObjC types
Summary: Extend protector naming code style guideline to cover RetainPtr with CF/ObjC ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-13 22:30 PDT by Brady Eidson
Modified: 2016-05-13 22:30 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-05-13 22:30:09 PDT 
Extend protector naming code style guideline to cover RetainPtr with CF/ObjC types

This is a logical extension of https://bugs.webkit.org/show_bug.cgi?id=157591

Allowed names should be like:
RetainPtr<id> protectedSelf(self);
RetainPtr<id> protector(view);
RetainPtr<id> protectedView(view);
RetainPtr<CFStringRef> protector(cfString);
RetainPtr<CFStringRef> protectedCFString(cfString);

A search through the current tree might also reveal common patterns with adoptNS and adoptCF that should also be accounted for.