Reproduction steps: 1. Install latest safari (or Tech Preview) 2. Open the internal perf dashboard's v3 summary page 3. Hover to one of the bars Expected result: Says either "Open charts" or lists the platforms that are missing or ones without baselines. Actual result: The title of the ratio bar does not show up.
Created attachment 278920 [details] Fixes the bug
Created attachment 278921 [details] Fixed builds
Created attachment 278922 [details] Fixed one more bug
<rdar://problem/26130658>
Comment on attachment 278922 [details] Fixed one more bug View in context: https://bugs.webkit.org/attachment.cgi?id=278922&action=review > Source/WebCore/dom/Node.h:282 > + ContainerNode* parentInComposedTree() const; What the both callers really need is parentElementInComposedTree. Neither is interested in non-elements. On the other hand it would be tricky to structure the loop right since the starting node is not necessarily an element.
(In reply to comment #5) > Comment on attachment 278922 [details] > Fixed one more bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=278922&action=review > > > Source/WebCore/dom/Node.h:282 > > + ContainerNode* parentInComposedTree() const; > > What the both callers really need is parentElementInComposedTree. Neither is > interested in non-elements. On the other hand it would be tricky to > structure the loop right since the starting node is not necessarily an > element. Yeah, and we'd need something like parentInComposedTree for the first node anyway.
Committed r200923: <http://trac.webkit.org/changeset/200923>
*** Bug 108302 has been marked as a duplicate of this bug. ***