Bug 157704 - jsc: samplingProfilerStackTraces() without starting sampling should not cause jsc to crash
Summary: jsc: samplingProfilerStackTraces() without starting sampling should not cause...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-13 20:58 PDT by Joseph Pecoraro
Modified: 2016-05-13 22:50 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (4.58 KB, patch)
2016-05-13 20:59 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-13 20:58:03 PDT
* SUMMARY
samplingProfilerStackTraces() without starting sampling should not cause jsc to crash

Instead of crashing, lets throw an exception instead.

* STEPS TO REPRODUCE
>>> samplingProfilerStackTraces()
  => RELEASE_ASSERT
Comment 1 Joseph Pecoraro 2016-05-13 20:59:29 PDT
Created attachment 278918 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-05-13 22:50:45 PDT
Comment on attachment 278918 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278918

Committed r200916: <http://trac.webkit.org/changeset/200916>
Comment 3 WebKit Commit Bot 2016-05-13 22:50:48 PDT
All reviewed patches have been landed.  Closing bug.