Bug 157697 - Fix JSBench cause math domain error in run-benchmark script.
Summary: Fix JSBench cause math domain error in run-benchmark script.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-13 17:34 PDT by dewei_zhu
Modified: 2016-05-13 21:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.59 KB, patch)
2016-05-13 17:38 PDT, dewei_zhu 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (852.29 KB, application/zip)
2016-05-13 18:19 PDT, Build Bot 		no flags Details
Patch for landing (2.59 KB, patch)
2016-05-13 21:08 PDT, dewei_zhu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2016-05-13 17:34:43 PDT 
Fix JSBench cause math domain error in run-benchmark script.
Comment 1 dewei_zhu 2016-05-13 17:38:47 PDT 
Created attachment 278900 [details]
Patch
Comment 2 Build Bot 2016-05-13 18:19:01 PDT 
Comment on attachment 278900 [details]
Patch

Attachment 278900 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1317498

New failing tests:
transitions/default-timing-function.html
Comment 3 Build Bot 2016-05-13 18:19:04 PDT 
Created attachment 278904 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Ryosuke Niwa 2016-05-13 19:49:58 PDT 
Comment on attachment 278900 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278900&action=review

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py:92
> +        # Be careful about round-off error when sample_stdev is 0.

Nit: Wrong indentation.
Comment 5 dewei_zhu 2016-05-13 21:08:25 PDT 
Created attachment 278919 [details]
Patch for landing
Comment 6 Ryosuke Niwa 2016-05-13 21:16:37 PDT 
Stephanie, could you merge this change back into your TA setup?
Comment 7 WebKit Commit Bot 2016-05-13 21:57:48 PDT 
Comment on attachment 278919 [details]
Patch for landing

Clearing flags on attachment: 278919

Committed r200914: <http://trac.webkit.org/changeset/200914>
Comment 8 WebKit Commit Bot 2016-05-13 21:57:53 PDT 
All reviewed patches have been landed.  Closing bug.