Bug 157696 - DFG/FTL have a few bugs in their reasoning about the scope
Summary: DFG/FTL have a few bugs in their reasoning about the scope
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-13 17:12 PDT by Saam Barati
Modified: 2020-05-23 06:01 PDT (History)
13 users (show)

See Also:

Attachments
patch (3.23 KB, patch)
2016-05-13 17:15 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (3.23 KB, patch)
2016-05-13 17:16 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-05-13 17:12:15 PDT 
1. We should ensure that the scope is always flushed to the stack. This means claiming every node reads the scope when the debugger is enabled.
2. The FTL just has a bug where it doesn't properly set the scope register.
Comment 1 Saam Barati 2016-05-13 17:15:54 PDT 
Created attachment 278897 [details]
patch
Comment 2 Saam Barati 2016-05-13 17:16:50 PDT 
Created attachment 278898 [details]
patch
Comment 3 WebKit Commit Bot 2016-05-13 19:02:19 PDT 
Comment on attachment 278898 [details]
patch

Clearing flags on attachment: 278898

Committed r200906: <http://trac.webkit.org/changeset/200906>
Comment 4 WebKit Commit Bot 2016-05-13 19:02:24 PDT 
All reviewed patches have been landed.  Closing bug.