Bug 157690 - Allocate MacGlyphToPathTranslator / CairoGlyphToPathTranslator on the stack
Summary: Allocate MacGlyphToPathTranslator / CairoGlyphToPathTranslator on the stack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-13 15:41 PDT by Chris Dumez
Modified: 2016-05-14 09:53 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.24 KB, patch)
2016-05-13 15:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.17 KB, patch)
2016-05-13 16:04 PDT, Chris Dumez 		mmaxfield: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-05-13 15:41:51 PDT 
Make GlyphToPathTranslator fast allocated.
Comment 1 Chris Dumez 2016-05-13 15:44:18 PDT 
Created attachment 278883 [details]
Patch
Comment 2 Chris Dumez 2016-05-13 15:46:38 PDT 
Other plan, I think we can just stack allocate it.
Comment 3 Myles C. Maxfield 2016-05-13 15:55:39 PDT 
The Cocoa ports only use the MacGlyphToPathTranslator, and it's only used in one function, and it isn't a very big object, so putting it on the stack is a better idea. I don't know why I put it on the stack originally (maybe I was just being dumb).

The other ports may have other subclasses of the GlyphToPathTranslator - it would be good if we could apply the same treatment to them too.
Comment 4 Chris Dumez 2016-05-13 16:04:37 PDT 
Created attachment 278884 [details]
Patch
Comment 5 Myles C. Maxfield 2016-05-14 02:39:28 PDT 
Comment on attachment 278884 [details]
Patch

r=me assuming you fix the red EWS bubbles
Comment 6 Chris Dumez 2016-05-14 09:53:15 PDT 
Committed r200919: <http://trac.webkit.org/changeset/200919>