Bug 157689 - Remove unused initializer for WebEvent on iOS
Summary: Remove unused initializer for WebEvent on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified iOS 9.3
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 157695
Blocks:
  Show dependency tree / graph
 
Reported: 2016-05-13 15:37 PDT by Enrica Casucci
Modified: 2016-06-02 15:50 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.52 KB, patch)
2016-05-13 15:40 PDT, Enrica Casucci 		andersca: review+
Details | Formatted Diff | Diff
Patch2 (14.74 KB, patch)
2016-05-13 16:19 PDT, Enrica Casucci 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2016-05-13 15:37:18 PDT 
Cleanup task.
Comment 1 Enrica Casucci 2016-05-13 15:40:48 PDT 
Created attachment 278882 [details]
Patch
Comment 2 Enrica Casucci 2016-05-13 16:19:54 PDT 
Created attachment 278889 [details]
Patch2

New patch that removes also characterSet.
Comment 3 Anders Carlsson 2016-05-13 16:33:19 PDT 
Comment on attachment 278889 [details]
Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=278889&action=review

> Source/WebKit/mac/ChangeLog:22
> +2016-05-13  Enrica Casucci  <enrica@apple.com>
> +
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * WebView/WebHTMLView.mm:
> +        (-[WebHTMLView _handleEditingKeyEvent:]):
> +

Duplicate change log.
Comment 4 Enrica Casucci 2016-05-13 16:38:25 PDT 
Committed revision 200894.
Comment 5 WebKit Commit Bot 2016-05-13 17:01:12 PDT 
Re-opened since this is blocked by bug 157695
Comment 6 Ryan Haddad 2016-05-13 17:05:08 PDT 
(In reply to comment #5)
> Re-opened since this is blocked by bug 157695

Link to iOS build failure with this change:
<https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20(Build)/builds/6286>

This also appears to have failed to build in EWS :(
<https://webkit-queues.webkit.org/results/1317202>
Comment 7 Enrica Casucci 2016-05-16 14:38:49 PDT 
Committed again with build fix.

Committed revision 200968.
Comment 8 Enrica Casucci 2016-05-16 14:41:47 PDT 
Forgot a piece of the change.
Now landed in Committed revision 200969.
Comment 9 Ryan Haddad 2016-05-16 15:18:11 PDT 
The iOS build is still broken as of r200969:
<https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20(Build)/builds/6343>
Comment 10 Ryan Haddad 2016-05-16 15:25:52 PDT 
Reopening.
Comment 11 Enrica Casucci 2016-05-17 10:51:26 PDT 
Build fix landed in 200979.