WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
157689
Remove unused initializer for WebEvent on iOS
https://bugs.webkit.org/show_bug.cgi?id=157689
Summary
Remove unused initializer for WebEvent on iOS
Enrica Casucci
Reported
2016-05-13 15:37:18 PDT
Cleanup task.
Attachments
Patch
(5.52 KB, patch)
2016-05-13 15:40 PDT
,
Enrica Casucci
andersca
: review+
Details
Formatted Diff
Diff
Patch2
(14.74 KB, patch)
2016-05-13 16:19 PDT
,
Enrica Casucci
andersca
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Enrica Casucci
Comment 1
2016-05-13 15:40:48 PDT
Created
attachment 278882
[details]
Patch
Enrica Casucci
Comment 2
2016-05-13 16:19:54 PDT
Created
attachment 278889
[details]
Patch2 New patch that removes also characterSet.
Anders Carlsson
Comment 3
2016-05-13 16:33:19 PDT
Comment on
attachment 278889
[details]
Patch2 View in context:
https://bugs.webkit.org/attachment.cgi?id=278889&action=review
> Source/WebKit/mac/ChangeLog:22 > +2016-05-13 Enrica Casucci <
enrica@apple.com
> > + > + Need a short description (OOPS!). > + Need the bug URL (OOPS!). > + > + Reviewed by NOBODY (OOPS!). > + > + * WebView/WebHTMLView.mm: > + (-[WebHTMLView _handleEditingKeyEvent:]): > +
Duplicate change log.
Enrica Casucci
Comment 4
2016-05-13 16:38:25 PDT
Committed revision 200894.
WebKit Commit Bot
Comment 5
2016-05-13 17:01:12 PDT
Re-opened since this is blocked by
bug 157695
Ryan Haddad
Comment 6
2016-05-13 17:05:08 PDT
(In reply to
comment #5
)
> Re-opened since this is blocked by
bug 157695
Link to iOS build failure with this change: <
https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20(Build)/builds/6286
> This also appears to have failed to build in EWS :( <
https://webkit-queues.webkit.org/results/1317202
>
Enrica Casucci
Comment 7
2016-05-16 14:38:49 PDT
Committed again with build fix. Committed revision 200968.
Enrica Casucci
Comment 8
2016-05-16 14:41:47 PDT
Forgot a piece of the change. Now landed in Committed revision 200969.
Ryan Haddad
Comment 9
2016-05-16 15:18:11 PDT
The iOS build is still broken as of
r200969
: <
https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20(Build)/builds/6343
>
Ryan Haddad
Comment 10
2016-05-16 15:25:52 PDT
Reopening.
Enrica Casucci
Comment 11
2016-05-17 10:51:26 PDT
Build fix landed in 200979.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug