Bug 157687 - All scrolling height/width values should be integral rounded.
Summary: All scrolling height/width values should be integral rounded.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-13 15:18 PDT by zalan
Modified: 2016-05-13 22:13 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.41 KB, patch)
2016-05-13 15:23 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (5.95 KB, patch)
2016-05-13 15:33 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-02 for mac-yosemite (1.30 MB, application/zip)
2016-05-13 16:21 PDT, WebKit Commit Bot
no flags Details
Patch (32.49 KB, patch)
2016-05-13 19:11 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (902.06 KB, application/zip)
2016-05-13 20:16 PDT, Build Bot
no flags Details
Patch (40.76 KB, patch)
2016-05-13 20:40 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-05-13 15:18:37 PDT
Until after we switch over to subpixel scrolling.
Comment 1 zalan 2016-05-13 15:23:35 PDT
Created attachment 278874 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-05-13 15:26:49 PDT
Comment on attachment 278874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278874&action=review

> Source/WebCore/rendering/RenderLayer.cpp:3007
> +    int x = minX + roundToInt(box->borderLeft());

Also need to fix verticalScrollbarStart()
Comment 3 zalan 2016-05-13 15:33:50 PDT
Created attachment 278879 [details]
Patch
Comment 4 WebKit Commit Bot 2016-05-13 16:11:52 PDT
The commit-queue encountered the following flaky tests while processing attachment 278879 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2016-05-13 16:11:55 PDT
The commit-queue encountered the following flaky tests while processing attachment 278879 [details]:

The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2016-05-13 16:21:39 PDT
Comment on attachment 278879 [details]
Patch

Rejecting attachment 278879 [details] from commit-queue.

New failing tests:
fast/css/vertical-text-overflow-ellipsis-text-align-right.html
fast/css/text-overflow-ellipsis-text-align-left.html
fast/css/text-overflow-input.html
fast/css/vertical-text-overflow-ellipsis-text-align-left.html
fast/css/vertical-text-overflow-ellipsis-text-align-center.html
fast/css/text-overflow-ellipsis-text-align-justify.html
fast/css/text-overflow-ellipsis-text-align-center.html
fast/css/vertical-text-overflow-ellipsis-text-align-justify.html
fast/css/text-overflow-ellipsis-text-align-right.html
Full output: http://webkit-queues.webkit.org/results/1317021
Comment 7 WebKit Commit Bot 2016-05-13 16:21:44 PDT
Created attachment 278890 [details]
Archive of layout-test-results from webkit-cq-02 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 zalan 2016-05-13 19:11:54 PDT
Created attachment 278908 [details]
Patch
Comment 9 Build Bot 2016-05-13 20:16:52 PDT
Comment on attachment 278908 [details]
Patch

Attachment 278908 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1317868

New failing tests:
fast/css/text-overflow-ellipsis-text-align-justify.html
fast/css/vertical-text-overflow-ellipsis-text-align-justify.html
fast/css/vertical-text-overflow-ellipsis-text-align-left.html
Comment 10 Build Bot 2016-05-13 20:16:55 PDT
Created attachment 278915 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 11 zalan 2016-05-13 20:40:55 PDT
Created attachment 278916 [details]
Patch
Comment 12 WebKit Commit Bot 2016-05-13 22:13:16 PDT
Comment on attachment 278916 [details]
Patch

Clearing flags on attachment: 278916

Committed r200915: <http://trac.webkit.org/changeset/200915>
Comment 13 WebKit Commit Bot 2016-05-13 22:13:20 PDT
All reviewed patches have been landed.  Closing bug.