Bug 157687 – All scrolling height/width values should be integral rounded.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

Until after we switch over to subpixel scrolling.

[zalan]

Created attachment 278874 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 278874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278874&action=review

> Source/WebCore/rendering/RenderLayer.cpp:3007
> +    int x = minX + roundToInt(box->borderLeft());

Also need to fix verticalScrollbarStart()

[zalan]

Created attachment 278879 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 278879 [details]:

transitions/default-timing-function.html bug 138901 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 278879 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 278879 [details]
Patch

Rejecting attachment 278879 [details] from commit-queue.

New failing tests:
fast/css/vertical-text-overflow-ellipsis-text-align-right.html
fast/css/text-overflow-ellipsis-text-align-left.html
fast/css/text-overflow-input.html
fast/css/vertical-text-overflow-ellipsis-text-align-left.html
fast/css/vertical-text-overflow-ellipsis-text-align-center.html
fast/css/text-overflow-ellipsis-text-align-justify.html
fast/css/text-overflow-ellipsis-text-align-center.html
fast/css/vertical-text-overflow-ellipsis-text-align-justify.html
fast/css/text-overflow-ellipsis-text-align-right.html
Full output: http://webkit-queues.webkit.org/results/1317021

[WebKit Commit Bot]

Created attachment 278890 [details]
Archive of layout-test-results from webkit-cq-02 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[zalan]

Created attachment 278908 [details]
Patch

[Build Bot]

Comment on attachment 278908 [details]
Patch

Attachment 278908 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1317868

New failing tests:
fast/css/text-overflow-ellipsis-text-align-justify.html
fast/css/vertical-text-overflow-ellipsis-text-align-justify.html
fast/css/vertical-text-overflow-ellipsis-text-align-left.html

[Build Bot]

Created attachment 278915 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[zalan]

Created attachment 278916 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 278916 [details]
Patch

Clearing flags on attachment: 278916

Committed r200915: <http://trac.webkit.org/changeset/200915>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.