Bug 157675 – Give CrossThreadCopier a default specialization for Vectors of objects

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Give CrossThreadCopier a generic specialization for Vectors of objects

[Brady Eidson]

Created attachment 278838 [details]
Patch v1

[WebKit Commit Bot]

Attachment 278838 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/CrossThreadCopier.h:170:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 278839 [details]
Patch

[Darin Adler]

Comment on attachment 278839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278839&action=review

> Source/WebCore/platform/CrossThreadCopier.h:170
> +    static Type copy(const Vector<T>& source)

I would have written const Type&.

> Source/WebCore/platform/CrossThreadCopier.h:176
> +

I would have omitted this blank line.

[Darin Adler]

Comment on attachment 278839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278839&action=review

> Source/WebCore/platform/CrossThreadCopier.h:168
> +template<typename T> struct CrossThreadCopierBase<false, false, Vector<T>> {

Could consider making this work for vectors with inline capacity too.

[Brady Eidson]

(In reply to comment #5)
> Comment on attachment 278839 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278839&action=review
> 
> > Source/WebCore/platform/CrossThreadCopier.h:168
> > +template<typename T> struct CrossThreadCopierBase<false, false, Vector<T>> {
> 
> Could consider making this work for vectors with inline capacity too.

I think this would require a second specialization, so I'll punt until it's actually needed (Which, since these are rare enough, might be never)

[Brady Eidson]

http://trac.webkit.org/changeset/200861