Bug 157674 - Web Inspector: Computed style shows both prefixed and unprefixed variants of properties
Summary: Web Inspector: Computed style shows both prefixed and unprefixed variants of ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-13 06:16 PDT by Antoine Quint
Modified: 2016-05-16 11:27 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.30 KB, patch)
2016-05-13 06:19 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (3.23 KB, patch)
2016-05-16 11:24 PDT, Antoine Quint
bburg: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-05-13 06:16:41 PDT
If you set an animation property, which is supported both prefixed and unprefixed in WebKit, both the prefixed and unprefixed variants will show in the computed styles. Only properties that are explicitly set should be shown.
Comment 1 Radar WebKit Bug Importer 2016-05-13 06:17:01 PDT
<rdar://problem/26266679>
Comment 2 Antoine Quint 2016-05-13 06:17:11 PDT
<rdar://problem/24339756>
Comment 3 Antoine Quint 2016-05-13 06:19:37 PDT
Created attachment 278837 [details]
Patch
Comment 4 Timothy Hatcher 2016-05-13 09:54:34 PDT
Comment on attachment 278837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278837&action=review

> Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:962
> +        return this._orderedStyles.some(function(style) {
> +            return style.properties.some(function (property) {

We have been using arrow functions for things like this. They are fast! Also no space before (.
Comment 5 Matt Baker 2016-05-13 13:41:47 PDT
Comment on attachment 278837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278837&action=review

> Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:211
> +

Lately we've been making simple getters/settings one line:
set implicit(implicit) { this._implicit = implicit; }
Comment 6 Antoine Quint 2016-05-16 11:24:55 PDT
Created attachment 279029 [details]
Patch for landing
Comment 7 Brian Burg 2016-05-16 11:25:41 PDT
Committed r200952: <http://trac.webkit.org/changeset/200952>
Comment 8 Brian Burg 2016-05-16 11:26:14 PDT
Comment on attachment 279029 [details]
Patch for landing

Already landed it through my local checkout.