Bug 157674 – Web Inspector: Computed style shows both prefixed and unprefixed variants of properties

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Antoine Quint]

If you set an animation property, which is supported both prefixed and unprefixed in WebKit, both the prefixed and unprefixed variants will show in the computed styles. Only properties that are explicitly set should be shown.

[Radar WebKit Bug Importer]

<rdar://problem/26266679>

[Antoine Quint]

<rdar://problem/24339756>

[Antoine Quint]

Created attachment 278837 [details]
Patch

[Timothy Hatcher]

Comment on attachment 278837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278837&action=review

> Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:962
> +        return this._orderedStyles.some(function(style) {
> +            return style.properties.some(function (property) {

We have been using arrow functions for things like this. They are fast! Also no space before (.

[Matt Baker]

Comment on attachment 278837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278837&action=review

> Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:211
> +

Lately we've been making simple getters/settings one line:
set implicit(implicit) { this._implicit = implicit; }

[Antoine Quint]

Created attachment 279029 [details]
Patch for landing

[Blaze Burg]

Committed r200952: <http://trac.webkit.org/changeset/200952>

[Blaze Burg]

Comment on attachment 279029 [details]
Patch for landing

Already landed it through my local checkout.