Bug 157673 - Turn on WEB_TIMING for all ports
Summary: Turn on WEB_TIMING for all ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-13 04:35 PDT by Yoav Weiss
Modified: 2016-05-17 00:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.37 KB, patch)
2016-05-13 04:37 PDT, Yoav Weiss 		no flags Details | Formatted Diff | Diff
Patch (4.54 KB, patch)
2016-05-13 04:43 PDT, Yoav Weiss 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoav Weiss 2016-05-13 04:35:14 PDT 
Turn on WEB_TIMING for all ports
Comment 1 Yoav Weiss 2016-05-13 04:37:46 PDT 
Created attachment 278834 [details]
Patch
Comment 2 Yoav Weiss 2016-05-13 04:39:18 PDT 
This turns on WEB_TIMING by default on the cmake Mac port, and makes sure that all ports have it on by default.
Comment 3 Yoav Weiss 2016-05-13 04:43:21 PDT 
Created attachment 278835 [details]
Patch
Comment 4 WebKit Commit Bot 2016-05-13 11:05:51 PDT 
Comment on attachment 278835 [details]
Patch

Clearing flags on attachment: 278835

Committed r200863: <http://trac.webkit.org/changeset/200863>
Comment 5 WebKit Commit Bot 2016-05-13 11:05:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2016-05-13 20:14:01 PDT 
Comment on attachment 278835 [details]
Patch

Awesome! How about we just remove the ENABLE flag entirely now that all ports enable it?
Comment 7 Yoav Weiss 2016-05-17 00:03:55 PDT 
(In reply to comment #6)
> Comment on attachment 278835 [details]
> Patch
> 
> Awesome! How about we just remove the ENABLE flag entirely now that all
> ports enable it?

I understood some people prefer to keep such flags in place in order to reduce binary size when building WebKit for e.g. embedded devices. OTOH, I'm not sure the impact of WEB_TIMING on binary size is significant. 

Should I ask webkit-dev before sending out a patch to remove the WEB_TIMING flag?