Bug 157664 - Web Inspector: DataGrid _updateVisibleRows dominates profiles of timeline recordings when data grid (Overview or TimelineDataGrids) is showing
Summary: Web Inspector: DataGrid _updateVisibleRows dominates profiles of timeline rec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-12 22:01 PDT by Joseph Pecoraro
Modified: 2022-03-01 02:43 PST (History)
9 users (show)

See Also:


Attachments
Patch (8.23 KB, patch)
2016-05-14 12:17 PDT, Timothy Hatcher
joepeck: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (828.62 KB, application/zip)
2016-05-14 12:59 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-12 22:01:09 PDT
* SUMMARY
DataGrid _updateVisibleRows dominates profiles of timeline recordings when data grid (Overview or TimelineDataGrids) is showing.

Profiling Web Inspector while recording a timeline with a DataGrid showing absolutely kills performance. Hiding DataGrids (e.g. Scripts and Events / ProfileView) Overview graphs are almost flawless!

* STEPS TO REPRODUCE
1. Inspect theverge.com
2. Show Timelines Tab
3. Show Network + Layout + Scripts timelines
4. Select Layout and Rendering Timeline to show DataGrid
5. Reload
  => Lots of Forced layouts dominating time in DataGrid _updateVisibleRows
Comment 1 Radar WebKit Bug Importer 2016-05-12 22:01:55 PDT
<rdar://problem/26262219>
Comment 2 Timothy Hatcher 2016-05-14 12:17:54 PDT
Created attachment 278942 [details]
Patch
Comment 3 Build Bot 2016-05-14 12:59:07 PDT
Comment on attachment 278942 [details]
Patch

Attachment 278942 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1321578

New failing tests:
imported/blink/storage/indexeddb/blob-basics-metadata.html
Comment 4 Build Bot 2016-05-14 12:59:10 PDT
Created attachment 278943 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Joseph Pecoraro 2016-05-16 10:46:24 PDT
Comment on attachment 278942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278942&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:804
>          if (layoutReason == WebInspector.View.LayoutReason.Resize || firstUpdate) {

Nit: You could drive by fix the == to ===

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1010
> +        if (isNaN(this._cachedScrollHeight))
> +            this._cachedScrollHeight = this._scrollContainerElement.offsetHeight;

Should we rename this offsetHeight given it is getting the offsetHeight instead of scrollHeight?
Comment 6 BJ Burg 2016-05-16 10:59:28 PDT
Comment on attachment 278942 [details]
Patch

r=me also
Comment 7 Timothy Hatcher 2016-05-16 11:04:05 PDT
https://trac.webkit.org/r200949