Bug 157662 - Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation
Summary: Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 154257
Blocks:
  Show dependency tree / graph
 
Reported: 2016-05-12 20:57 PDT by Chris Dumez
Modified: 2016-05-12 23:27 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2016-05-12 21:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-05-12 20:57:21 PDT 
Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation as it is no longer needed after <http://trac.webkit.org/changeset/196678>.
JSC::getStaticPropertySlot() now properly checks for overrides *before* checking the static table.
Comment 1 Chris Dumez 2016-05-12 21:00:02 PDT 
Created attachment 278809 [details]
Patch
Comment 2 Chris Dumez 2016-05-12 21:00:41 PDT 
The generated bindings look like so:
bool JSWorkerGlobalScope::getOwnPropertySlot(JSObject* object, ExecState* state, PropertyName propertyName, PropertySlot& slot)
{
    auto* thisObject = jsCast<JSWorkerGlobalScope*>(object);
    ASSERT_GC_OBJECT_INHERITS(thisObject, info());
    if (getStaticPropertySlot<JSWorkerGlobalScope, Base>(state, JSWorkerGlobalScopeTable, thisObject, propertyName, slot))
        return true;
    return false;
}
Comment 3 WebKit Commit Bot 2016-05-12 23:27:44 PDT 
Comment on attachment 278809 [details]
Patch

Clearing flags on attachment: 278809

Committed r200814: <http://trac.webkit.org/changeset/200814>
Comment 4 WebKit Commit Bot 2016-05-12 23:27:50 PDT 
All reviewed patches have been landed.  Closing bug.