Bug 157640 - Web Inspector: Layout timeline popovers are inconsistently shown
Summary: Web Inspector: Layout timeline popovers are inconsistently shown
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-12 14:16 PDT by Joseph Pecoraro
Modified: 2016-05-12 15:07 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (5.38 KB, patch)
2016-05-12 14:19 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-12 14:16:46 PDT 
* SUMMARY
Layout timeline popovers are inconsistently shown

* STEPS TO REPRODUCE
1. Record a timeline with Layout records containing JavaScript backtraces
2. Click around Layout Timeline datagrid
  => Sometimes Popovers do not show up
Comment 1 Radar WebKit Bug Importer 2016-05-12 14:17:26 PDT 
<rdar://problem/26253394>
Comment 2 Joseph Pecoraro 2016-05-12 14:19:24 PDT 
Created attachment 278759 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2016-05-12 15:01:55 PDT 
Comment on attachment 278759 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278759&action=review

> Source/WebInspectorUI/ChangeLog:18
> +        Updating with presentNewContentWithFrame animates the popover to the correct
> +        position instead of jumping and ending up at the wrong location.

I don't think we should ever animate a popover from one spot to another. It should only ever animate in/out. Not move. This sin't new, but we should consider changing it. It just looks silly.
Comment 4 WebKit Commit Bot 2016-05-12 15:07:37 PDT 
Comment on attachment 278759 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278759

Committed r200792: <http://trac.webkit.org/changeset/200792>
Comment 5 WebKit Commit Bot 2016-05-12 15:07:41 PDT 
All reviewed patches have been landed.  Closing bug.