Bug 157632 - Unprefix -webkit-cross-fade()
Summary: Unprefix -webkit-cross-fade()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-05-12 11:48 PDT by Simon Fraser (smfr)
Modified: 2017-11-22 05:32 PST (History)
6 users (show)

See Also:

Attachments
Patch (39.23 KB, patch)
2016-05-12 21:34 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-05-12 11:48:35 PDT 
We should unprefix this: https://drafts.csswg.org/css-images/#cross-fade-function
Comment 1 Simon Fraser (smfr) 2016-05-12 21:34:20 PDT 
Created attachment 278813 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-05-13 15:40:34 PDT 
https://trac.webkit.org/r200888
Comment 3 yisibl 2016-05-25 22:43:14 PDT 
Webkit implementation of the grammar and the latest spec are not the same.

cross-fade() = cross-fade( <cf-mixing-image> , <cf-final-image>? )
<cf-mixing-image> = <percentage>? && <image>
<cf-final-image> = <image> | <color>

So we have to put the percentage in front of it, and remove the comma.

Before:
-webkit-cross-fade(url(foo.png), url(bar.png), 20%)

After:
cross-fade(20% url(foo.png), url(bar.png))
Comment 4 yisibl 2016-05-25 22:45:10 PDT 
And support <color> 

cross-fade(20% url(foo.png), #000)
Comment 5 Fredrik Söderquist 2017-11-22 05:32:05 PST 
I filed bug 179942 for following up on comment 3.