Bug 157618 - Web Inspector: Reduce rAF churn in DefaultDashboardView on pages with lots of resources
Summary: Web Inspector: Reduce rAF churn in DefaultDashboardView on pages with lots of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-05-12 01:24 PDT by Joseph Pecoraro
Modified: 2016-05-12 08:41 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.46 KB, patch)
2016-05-12 01:25 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-12 01:24:07 PDT 
* SUMMARY
Reduce rAF churn in DefaultDashboardView on pages with lots of resources.

Each resource added would cause a separate rAF to be added. That means there would be lots of duplicate work when the rAFs do fire with the same callback and data all at the same time.
Comment 1 Joseph Pecoraro 2016-05-12 01:25:10 PDT 
Created attachment 278714 [details]
[PATCH] Proposed Fix
Comment 2 Timothy Hatcher 2016-05-12 08:20:18 PDT 
Comment on attachment 278714 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278714&action=review

> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:68
> +    _updateDisplaySoon()

I wonder if we should add a soon Proxy using rAF?
Comment 3 WebKit Commit Bot 2016-05-12 08:41:46 PDT 
Comment on attachment 278714 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278714

Committed r200772: <http://trac.webkit.org/changeset/200772>
Comment 4 WebKit Commit Bot 2016-05-12 08:41:50 PDT 
All reviewed patches have been landed.  Closing bug.