Bug 157615 - [css-grid] Incorrect parsing when using just 'span" as grid-line value
Summary: [css-grid] Incorrect parsing when using just 'span" as grid-line value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL: https://bugs.chromium.org/p/chromium/...
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2016-05-12 00:37 PDT by Manuel Rego Casasnovas
Modified: 2016-05-12 02:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (18.67 KB, patch)
2016-05-12 00:54 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-05-12 00:37:53 PDT 
If you use "span" alone to reference a grid line it should be considered an invalid declaration (e.g. "grid-column: span;").
https://drafts.csswg.org/css-grid/#typedef-grid-row-start-grid-line

This is a port from a Blink patch: https://codereview.chromium.org/1970573004/
Comment 1 Manuel Rego Casasnovas 2016-05-12 00:54:37 PDT 
Created attachment 278708 [details]
Patch
Comment 2 WebKit Commit Bot 2016-05-12 02:11:23 PDT 
Comment on attachment 278708 [details]
Patch

Clearing flags on attachment: 278708

Committed r200755: <http://trac.webkit.org/changeset/200755>
Comment 3 WebKit Commit Bot 2016-05-12 02:11:26 PDT 
All reviewed patches have been landed.  Closing bug.