Bug 157609 - TextIteratorStopsOnFormControls is never used
Summary: TextIteratorStopsOnFormControls is never used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-11 22:09 PDT by Ryosuke Niwa
Modified: 2016-05-11 23:46 PDT (History)
4 users (show)

See Also:


Attachments
Cleanup (9.06 KB, patch)
2016-05-11 22:14 PDT, Ryosuke Niwa
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-05-11 22:09:59 PDT
TextIteratorStopsOnFormControls is only used in SurroundingText.cpp but this file is not used in any port.
This must be a left over from Chromium port.
Comment 1 Ryosuke Niwa 2016-05-11 22:14:06 PDT
Created attachment 278697 [details]
Cleanup
Comment 2 Alex Christensen 2016-05-11 23:20:53 PDT
Comment on attachment 278697 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=278697&action=review

> Source/WebCore/editing/TextIterator.cpp:1189
> +    : m_behavior(TextIteratorDefaultBehavior)

m_behavior { TextIteratorDefaultBehavior } in the header.  Same with a lot of these.
Comment 3 Ryosuke Niwa 2016-05-11 23:46:44 PDT
Committed r200744: <http://trac.webkit.org/changeset/200744>