Bug 157607 - Web Inspector: 4% of time in TimelineOverviewGraph adding/removing classList styles on TimelineRecordBar
Summary: Web Inspector: 4% of time in TimelineOverviewGraph adding/removing classList ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-05-11 20:36 PDT by Joseph Pecoraro
Modified: 2016-05-11 21:32 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (4.53 KB, patch)
2016-05-11 20:38 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-11 20:36:07 PDT 
4% of time in TimelineOverviewGraph on theverge.com is adding/removing classList styles on TimelineRecordBar.

We can eliminate a lot of these by just being smarter about only toggling them when they change.
Comment 1 Joseph Pecoraro 2016-05-11 20:38:24 PDT 
Created attachment 278691 [details]
[PATCH] Proposed Fix
Comment 2 BJ Burg 2016-05-11 21:10:16 PDT 
Comment on attachment 278691 [details]
[PATCH] Proposed Fix

r=me

Good catch.
Comment 3 WebKit Commit Bot 2016-05-11 21:32:04 PDT 
Comment on attachment 278691 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278691

Committed r200740: <http://trac.webkit.org/changeset/200740>
Comment 4 WebKit Commit Bot 2016-05-11 21:32:08 PDT 
All reviewed patches have been landed.  Closing bug.