Bug 157603 - [JSC] Make sure StringRange is passed to Vector by register
Summary: [JSC] Make sure StringRange is passed to Vector by register
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-11 18:37 PDT by Benjamin Poulain
Modified: 2016-05-11 23:33 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.67 KB, patch)
2016-05-11 18:45 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-05-11 18:37:54 PDT 
[JSC] Make sure StringRange is passed to Vector by register
Comment 1 Benjamin Poulain 2016-05-11 18:45:24 PDT 
Created attachment 278689 [details]
Patch
Comment 2 Benjamin Poulain 2016-05-11 23:14:36 PDT 
After updating to a more recent LLVM, I see the same thing.
Vector::append() is not inlined in this case. It is just weird.
Comment 3 WebKit Commit Bot 2016-05-11 23:33:51 PDT 
Comment on attachment 278689 [details]
Patch

Clearing flags on attachment: 278689

Committed r200743: <http://trac.webkit.org/changeset/200743>
Comment 4 WebKit Commit Bot 2016-05-11 23:33:56 PDT 
All reviewed patches have been landed.  Closing bug.