Bug 157602 - Web Inspector: `this` in Scope Chain Sidebar does not have preview, looks poor
Summary: Web Inspector: `this` in Scope Chain Sidebar does not have preview, looks poor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-05-11 17:48 PDT by Joseph Pecoraro
Modified: 2016-05-11 19:13 PDT (History)
12 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.55 KB, patch)
2016-05-11 17:49 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[IMAGE] Before (104.93 KB, image/png)
2016-05-11 17:52 PDT, Joseph Pecoraro
no flags Details
[IMAGE] After (110.28 KB, image/png)
2016-05-11 17:52 PDT, Joseph Pecoraro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-11 17:48:23 PDT
* SUMMARY
`this` in Scope Chain Sidebar does not have preview, looks poor

* TEST
<body><img id="x">
<script>
function foo() {
    let x = 1;
    console.log(this);
    debugger;
}
foo.call(window.x);
</script>

* STEPS TO REPRODUCE
1. Inspect test page
2. Reload
  => Pause
3. Show Scope Chain Sidebar in Debugger Tab
  => The `this` in the Local Variables scope is not pretty, because it lacks a preview
Comment 1 Joseph Pecoraro 2016-05-11 17:49:26 PDT
Created attachment 278686 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2016-05-11 17:52:09 PDT
Created attachment 278687 [details]
[IMAGE] Before
Comment 3 Joseph Pecoraro 2016-05-11 17:52:21 PDT
Created attachment 278688 [details]
[IMAGE] After
Comment 4 WebKit Commit Bot 2016-05-11 19:13:01 PDT
Comment on attachment 278686 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278686

Committed r200737: <http://trac.webkit.org/changeset/200737>
Comment 5 WebKit Commit Bot 2016-05-11 19:13:06 PDT
All reviewed patches have been landed.  Closing bug.