WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
157593
Web Inspector: Make it possible to do special styling on selected TimelineOverviewGraphs
https://bugs.webkit.org/show_bug.cgi?id=157593
Summary
Web Inspector: Make it possible to do special styling on selected TimelineOve...
Matt Baker
Reported
2016-05-11 15:55:01 PDT
* SUMMARY Make it possible to do special styling for selected TimelineOverviewGraphs. Selecting a timeline in the overview's outline should add a "selected" class on the its overview graph element, to expose this state to CSS.
Attachments
[Patch] Proposed Fix
(4.37 KB, patch)
2016-05-11 16:04 PDT
,
Matt Baker
no flags
Details
Formatted Diff
Diff
[Patch] Proposed Fix
(4.39 KB, patch)
2016-05-11 16:31 PDT
,
Matt Baker
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-05-11 15:57:18 PDT
<
rdar://problem/26232886
>
Radar WebKit Bug Importer
Comment 2
2016-05-11 15:59:14 PDT
<
rdar://problem/26232856
>
Matt Baker
Comment 3
2016-05-11 16:04:32 PDT
Created
attachment 278677
[details]
[Patch] Proposed Fix
Timothy Hatcher
Comment 4
2016-05-11 16:19:38 PDT
Comment on
attachment 278677
[details]
[Patch] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=278677&action=review
> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:794 > + function selectOverviewGraph(timeline, selected)
selectOverviewGraph is an odd name since it takes a selected argument. Maybe updateSelectedState()?
Matt Baker
Comment 5
2016-05-11 16:31:19 PDT
Created
attachment 278680
[details]
[Patch] Proposed Fix
WebKit Commit Bot
Comment 6
2016-05-11 17:00:47 PDT
Comment on
attachment 278680
[details]
[Patch] Proposed Fix Clearing flags on attachment: 278680 Committed
r200716
: <
http://trac.webkit.org/changeset/200716
>
WebKit Commit Bot
Comment 7
2016-05-11 17:00:51 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug