Bug 157593 - Web Inspector: Make it possible to do special styling on selected TimelineOverviewGraphs
Summary: Web Inspector: Make it possible to do special styling on selected TimelineOve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks: 157588
  Show dependency treegraph
 
Reported: 2016-05-11 15:55 PDT by Matt Baker
Modified: 2016-05-11 17:00 PDT (History)
8 users (show)

See Also:


Attachments
[Patch] Proposed Fix (4.37 KB, patch)
2016-05-11 16:04 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (4.39 KB, patch)
2016-05-11 16:31 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-05-11 15:55:01 PDT
* SUMMARY
Make it possible to do special styling for selected TimelineOverviewGraphs. Selecting a timeline in the overview's outline should add a "selected" class on the its overview graph element, to expose this state to CSS.
Comment 1 Radar WebKit Bug Importer 2016-05-11 15:57:18 PDT
<rdar://problem/26232886>
Comment 2 Radar WebKit Bug Importer 2016-05-11 15:59:14 PDT
<rdar://problem/26232856>
Comment 3 Matt Baker 2016-05-11 16:04:32 PDT
Created attachment 278677 [details]
[Patch] Proposed Fix
Comment 4 Timothy Hatcher 2016-05-11 16:19:38 PDT
Comment on attachment 278677 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278677&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:794
> +        function selectOverviewGraph(timeline, selected)

selectOverviewGraph is an odd name since it takes a selected argument. Maybe updateSelectedState()?
Comment 5 Matt Baker 2016-05-11 16:31:19 PDT
Created attachment 278680 [details]
[Patch] Proposed Fix
Comment 6 WebKit Commit Bot 2016-05-11 17:00:47 PDT
Comment on attachment 278680 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 278680

Committed r200716: <http://trac.webkit.org/changeset/200716>
Comment 7 WebKit Commit Bot 2016-05-11 17:00:51 PDT
All reviewed patches have been landed.  Closing bug.