Bug 157590 – Web Inspector: Contents of Duration column are covered by always on (legacy) scroll bars

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

rdar://problem/24846037

[Nikita Vasilyev]

Created attachment 278671 [details]
WIP

[Nikita Vasilyev]

Created attachment 278672 [details]
[Image] With the patch applied

[Nikita Vasilyev]

Created attachment 278675 [details]
[Image] Bug

(In reply to comment #1)
> Created attachment 278671 [details]
> WIP

Sometimes it looks like this :\

[Timothy Hatcher]

(In reply to comment #3)
> Sometimes it looks like this :\

Is _updateScrollbarPadding over compensating?

[Nikita Vasilyev]

Comment on attachment 278671 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=278671&action=review

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:327
> +        var scrollBarWidth = this._scrollContainerElement.offsetWidth - this._scrollContainerElement.clientWidth;

Sometimes scrollBarWidth is 0.

I have a couple of pure HTML & CSS ideas that would make this method obsolete.

[Nikita Vasilyev]

Created attachment 278679 [details]
Patch

[Timothy Hatcher]

Comment on attachment 278679 [details]
Patch

Clever!

[WebKit Commit Bot]

Comment on attachment 278679 [details]
Patch

Clearing flags on attachment: 278679

Committed r200718: <http://trac.webkit.org/changeset/200718>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Nikita Vasilyev]

This converts the default overlay scrollbar to the always visible one:

    ::-webkit-scrollbar { /* any property */ }

Back to the drawing board.

[Nikita Vasilyev]

Created attachment 278974 [details]
Patch

[Nikita Vasilyev]

The current patch looks a lot like the first WIP. However,

(In reply to comment #3)
> Created attachment 278675 [details]
> [Image] Bug
> 
> (In reply to comment #1)
> > Created attachment 278671 [details]
> > WIP
> 
> Sometimes it looks like this :\

This issue was addressed by running _updateScrollbarPadding
on every layout call.

[WebKit Commit Bot]

Comment on attachment 278974 [details]
Patch

Rejecting attachment 278974 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 278974, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Interface/Views/DataGrid.js
Hunk #1 succeeded at 59 with fuzz 2 (offset 6 lines).
Hunk #2 succeeded at 69 (offset 6 lines).
Hunk #3 succeeded at 116 (offset 6 lines).
Hunk #4 succeeded at 126 (offset 6 lines).
Hunk #5 FAILED at 828.
1 out of 5 hunks FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/DataGrid.js.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1331873

[Nikita Vasilyev]

Created attachment 279037 [details]
Patch

Rebaselined.

[WebKit Commit Bot]

Comment on attachment 279037 [details]
Patch

Clearing flags on attachment: 279037

Committed r200962: <http://trac.webkit.org/changeset/200962>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.