Bug 157585 – Moving focus by tab could erroneously focus a non-focusable shadow host

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

There is a bug that when moving into an iframe by tab key press,
we can end up focusing a non-focusable shadow-host, which is wrong.

[Ryosuke Niwa]

Created attachment 278664 [details]
Fixes the bug

[Antti Koivisto]

Comment on attachment 278664 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=278664&action=review

> Source/WebCore/page/FocusController.cpp:438
> +        FocusNavigationScope outerScope = FocusNavigationScope::scopeOf(*owner);

could use auto

[Radar WebKit Bug Importer]

<rdar://problem/26229770>

[Ryosuke Niwa]

(In reply to comment #2)
> Comment on attachment 278664 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278664&action=review
> 
> > Source/WebCore/page/FocusController.cpp:438
> > +        FocusNavigationScope outerScope = FocusNavigationScope::scopeOf(*owner);
> 
> could use auto

Will fix.  Thanks!

[Build Bot]

Comment on attachment 278664 [details]
Fixes the bug

Attachment 278664 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1305595

New failing tests:
fast/shadow-dom/focus-on-iframe.html

[Build Bot]

Created attachment 278669 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Ryosuke Niwa]

Committed r200712: <http://trac.webkit.org/changeset/200712>