Bug 157584 - Beef up JSC profiler event log
Summary: Beef up JSC profiler event log
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-11 13:31 PDT by Filip Pizlo
Modified: 2016-05-11 14:41 PDT (History)
5 users (show)

See Also:

Attachments
the patch (10.78 KB, patch)
2016-05-11 13:47 PDT, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-05-11 13:31:18 PDT 
Also log more about compilation.
Comment 1 Filip Pizlo 2016-05-11 13:47:52 PDT 
Created attachment 278663 [details]
the patch
Comment 2 WebKit Commit Bot 2016-05-11 13:50:09 PDT 
Attachment 278663 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:225:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2016-05-11 14:33:42 PDT 
Comment on attachment 278663 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278663&action=review

r=me

> Source/JavaScriptCore/dfg/DFGPlan.cpp:222
> +        RELEASE_ASSERT_NOT_REACHED();

Do we need that stupid COMPILE_QUIRK(...) thingy here?
Comment 4 Filip Pizlo 2016-05-11 14:34:57 PDT 
(In reply to comment #3)
> Comment on attachment 278663 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278663&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGPlan.cpp:222
> > +        RELEASE_ASSERT_NOT_REACHED();
> 
> Do we need that stupid COMPILE_QUIRK(...) thingy here?

No because I unconditionally initialized the variable to null.
Comment 5 Filip Pizlo 2016-05-11 14:41:28 PDT 
Landed in http://trac.webkit.org/changeset/200705