Bug 157583 - Web Inspector: Hide filter bar in TimelineViews where it is not needed or not yet working
Summary: Web Inspector: Hide filter bar in TimelineViews where it is not needed or not...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-05-11 13:26 PDT by Joseph Pecoraro
Modified: 2016-05-11 14:52 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (8.47 KB, patch)
2016-05-11 13:36 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-05-11 13:26:44 PDT 
* SUMMARY
Hide filter bar in TimelineViews where it is not needed or not yet working

- Memory Timeline View - not needed
- Heap Snapshot View - not hooked up yet
<https://webkit.org/b/157582> Web Inspector: Heap Snapshot Views should be searchable
- Script Profile View - not hooked up yet
<https://webkit.org/b/157581> Web Inspector: Script ProfileViews should be searchable
Comment 1 Joseph Pecoraro 2016-05-11 13:36:21 PDT 
Created attachment 278661 [details]
[PATCH] Proposed Fix
Comment 2 Radar WebKit Bug Importer 2016-05-11 13:36:51 PDT 
<rdar://problem/26228913>
Comment 3 Matt Baker 2016-05-11 13:48:42 PDT 
Comment on attachment 278661 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278661&action=review

> Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js:259
> +

Usually this is handled by the base class, but that requires HeapAllocationsTimelineView to call TimelineView.setupDataGrid in its constructor. Fine for now.
Comment 4 Joseph Pecoraro 2016-05-11 13:52:38 PDT 
(In reply to comment #3)
> Comment on attachment 278661 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278661&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js:259
> > +
> 
> Usually this is handled by the base class, but that requires
> HeapAllocationsTimelineView to call TimelineView.setupDataGrid in its
> constructor. Fine for now.

I describe in the ChangeLog why we don't use the default TimelineView filtering (we show all snapshots regardless of the timeline range selection). Maybe that is bad?
Comment 5 WebKit Commit Bot 2016-05-11 14:52:37 PDT 
Comment on attachment 278661 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278661

Committed r200708: <http://trac.webkit.org/changeset/200708>
Comment 6 WebKit Commit Bot 2016-05-11 14:52:41 PDT 
All reviewed patches have been landed.  Closing bug.