Bug 157583 – Web Inspector: Hide filter bar in TimelineViews where it is not needed or not yet working

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Hide filter bar in TimelineViews where it is not needed or not yet working

- Memory Timeline View - not needed
- Heap Snapshot View - not hooked up yet
<https://webkit.org/b/157582> Web Inspector: Heap Snapshot Views should be searchable
- Script Profile View - not hooked up yet
<https://webkit.org/b/157581> Web Inspector: Script ProfileViews should be searchable

[Joseph Pecoraro]

Created attachment 278661 [details]
[PATCH] Proposed Fix

[Radar WebKit Bug Importer]

<rdar://problem/26228913>

[Matt Baker]

Comment on attachment 278661 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=278661&action=review

> Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js:259
> +

Usually this is handled by the base class, but that requires HeapAllocationsTimelineView to call TimelineView.setupDataGrid in its constructor. Fine for now.

[Joseph Pecoraro]

(In reply to comment #3)
> Comment on attachment 278661 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278661&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js:259
> > +
> 
> Usually this is handled by the base class, but that requires
> HeapAllocationsTimelineView to call TimelineView.setupDataGrid in its
> constructor. Fine for now.

I describe in the ChangeLog why we don't use the default TimelineView filtering (we show all snapshots regardless of the timeline range selection). Maybe that is bad?

[WebKit Commit Bot]

Comment on attachment 278661 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 278661

Committed r200708: <http://trac.webkit.org/changeset/200708>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.